Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] HTML crawl regression #3677

Merged
merged 2 commits into from Feb 2, 2022

Conversation

Conduitry
Copy link
Member

Whoops. #3668 introduced a bunch of huge bugs because substr is not the same as substring. We could keep using substr even though it's deprecated, or we could rewrite this. I've opted for the former because I want to get this fixed quickly.

There are also no new tests. Ideally this dumb bug would have been caught by a test, but it wasn't, and I'm not going to write more right now, also because I want to get this fixed quickly.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2022

🦋 Changeset detected

Latest commit: ee5d625

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 2, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: ee5d625

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61fa007243e20a0007506377

@Rich-Harris Rich-Harris merged commit e982472 into sveltejs:master Feb 2, 2022
@github-actions github-actions bot mentioned this pull request Feb 2, 2022
@Conduitry Conduitry deleted the crawl-revert-substr branch February 2, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants