-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full text search #3717
Full text search #3717
Conversation
|
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: c315589 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/62040293f2beaf0007d66fab |
@ghostdevv at present the content that powers the search box is available at /content.json. The table of doc contents is at /docs.json, and individual sections (with content) are at /docs/introduction.json etc. The bot might need some rejiggering but I think everything it needs should be available. Having said that those URLs might change if this switches over to use shadow endpoints — /docs/introduction/__data.json etc. |
@Rich-Harris thanks! We can work with that for sure |
Step 6 of #3696.
Preview deployment: https://kit-svelte-dev-git-flexsearch-svelte.vercel.app/
WIP. Adds a search bar powered by https://github.com/nextapps-de/flexsearch. Needs lots of design work and debugging (and @geoffrich, if you get a chance, I'd be very grateful for any a11y pointers), but as a proof of concept it does the trick.
Once it's in better shape, we can move to multi-page docs (and move migrating/FAQ into the docs — they don't need to be separate links, I don't think).
One known issue: I haven't figured out how to make a 'clean'
marked
instance — oncemarked.use(...)
gets called, the options are used everywhere, which means that theplaintext
stuff in this PR affects the generation of the docs themselves (which should only affect local development, but is annoying nonetheless).content.json
has been generatedTasks specific to multi-page redesign:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0