Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] spelling of .DS_Store #3823

Merged
merged 2 commits into from Feb 11, 2022
Merged

[fix] spelling of .DS_Store #3823

merged 2 commits into from Feb 11, 2022

Conversation

malinowskip
Copy link
Contributor

The spelling of .DS_Store in the default config is incorrect. As a result, .DS_Store files are not filtered out from the files array passed to the service worker.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2022

🦋 Changeset detected

Latest commit: e32ecc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 10, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: e32ecc4

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/6205d49514da1b0007549a90

@Conduitry
Copy link
Member

Should we just use a case insensitive regex, or is this always .DS_Store?

@Rich-Harris
Copy link
Member

thanks!

Should we just use a case insensitive regex, or is this always .DS_Store?

i've never seen it cased any other way (except in our docs, apparently)

@Conduitry
Copy link
Member

This isn't just changing the docs, it's also changing Kit, so this would need to include a changeset in order to be released.

@malinowskip
Copy link
Contributor Author

OK, I’ve added a changeset. Let me know in case any other adjustments are needed.

@benmccann benmccann merged commit 7979389 into sveltejs:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants