New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] default handlers for head #3903
[fix] default handlers for head #3903
Conversation
🦋 Changeset detectedLatest commit: dfdb6c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: dfdb6c1 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/620ace4cb6e8bd00087e23d0 |
@@ -40,9 +40,13 @@ export function is_text(content_type) { | |||
* @returns {Promise<Response | undefined>} | |||
*/ | |||
export async function render_endpoint(event, mod) { | |||
const method = event.request.method.toLowerCase().replace('delete', 'del'); // 'delete' is a reserved word |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code was already present, but I feel like .replace()
isn't the best way to deal with this, for a few reasons. What if we just do something like:
const method = event.request.method.toLowerCase().replace('delete', 'del'); // 'delete' is a reserved word | |
let method = event.request.method.toLowerCase(); | |
if (method === 'delete') { // 'delete' is a reserved word | |
method = 'del'; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved it to a util as it was used in two places
Co-authored-by: Rich Harris <hello@rich-harris.dev>
…it into fix/default-handlers-for-head
I just pushed a cosmetic change — the camelCased variables conflicted with the code style, and it was a bit of a wall-of-text, but it was tricky to do in a commit suggestion |
Co-authored-by: Rich Harris <hello@rich-harris.dev>
see #3894
add default handling for HEAD requests. follow "get" handling but do not return body in the end.
custom
head
handlers in endpoint files are respected and take precedence over get.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0