Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] default handlers for head #3903

Merged
merged 13 commits into from Feb 14, 2022

Conversation

dominikg
Copy link
Member

see #3894

add default handling for HEAD requests. follow "get" handling but do not return body in the end.
custom head handlers in endpoint files are respected and take precedence over get.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2022

🦋 Changeset detected

Latest commit: dfdb6c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 14, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: dfdb6c1

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/620ace4cb6e8bd00087e23d0

@@ -40,9 +40,13 @@ export function is_text(content_type) {
* @returns {Promise<Response | undefined>}
*/
export async function render_endpoint(event, mod) {
const method = event.request.method.toLowerCase().replace('delete', 'del'); // 'delete' is a reserved word
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code was already present, but I feel like .replace() isn't the best way to deal with this, for a few reasons. What if we just do something like:

Suggested change
const method = event.request.method.toLowerCase().replace('delete', 'del'); // 'delete' is a reserved word
let method = event.request.method.toLowerCase();
if (method === 'delete') { // 'delete' is a reserved word
method = 'del';
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved it to a util as it was used in two places

Co-authored-by: Rich Harris <hello@rich-harris.dev>
@Rich-Harris
Copy link
Member

I just pushed a cosmetic change — the camelCased variables conflicted with the code style, and it was a bit of a wall-of-text, but it was tricky to do in a commit suggestion

packages/kit/src/runtime/server/endpoint.js Outdated Show resolved Hide resolved
packages/kit/src/runtime/server/endpoint.js Outdated Show resolved Hide resolved
packages/kit/src/runtime/server/page/load_node.js Outdated Show resolved Hide resolved
packages/kit/src/runtime/server/page/load_node.js Outdated Show resolved Hide resolved
packages/kit/src/runtime/server/utils.js Outdated Show resolved Hide resolved
Co-authored-by: Rich Harris <hello@rich-harris.dev>
@Rich-Harris Rich-Harris merged commit 012850e into sveltejs:master Feb 14, 2022
@bluwy bluwy mentioned this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants