Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Disable meta http-equiv in static amp #4073

Merged
merged 2 commits into from Feb 23, 2022

Conversation

asendia
Copy link
Contributor

@asendia asendia commented Feb 23, 2022

Fixes invalid meta http-equiv tags in static amp docs: #4074

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: AMP 'http-equiv' may not appear in tag 'meta' #4074
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2022

🦋 Changeset detected

Latest commit: 6bcec44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@asendia asendia marked this pull request as ready for review February 23, 2022 10:39
@asendia asendia changed the title Disable http-equiv in AMP [fix] disable http-equiv in AMP Feb 23, 2022
@asendia asendia changed the title [fix] disable http-equiv in AMP [fix] disable http-equiv in static amp Feb 23, 2022
@asendia asendia changed the title [fix] disable http-equiv in static amp [fix] Disable meta http-equiv in static amp Feb 23, 2022
@Rich-Harris Rich-Harris merged commit 10f555d into sveltejs:master Feb 23, 2022
@Rich-Harris
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants