Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Use headers.raw() on split_headers #4096

Merged

Conversation

JeanJPNM
Copy link
Contributor

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Fixes #4087 by using the headers.raw() method from node-fetch to get the array of cookie headers.

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2022

🦋 Changeset detected

Latest commit: 8832e00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Auroratide
Copy link
Contributor

Auroratide commented Feb 23, 2022

Interesting! Didn't know about the raw() method, as it's specific to node-fetch.

I had started on a branch of my own by adding some testing, as there didn't seem to be any for the adapter. Are tests like these desired for a function of this scope?

@Rich-Harris Rich-Harris merged commit c1bf43e into sveltejs:master Feb 24, 2022
@Rich-Harris
Copy link
Member

thanks! definitely not opposed to adding some tests — our convention for unit tests is to have e.g. a headers.spec.js file alongside headers.js rather than putting them all in a central test.js file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netlify Adapter splits set-cookie headers at commas, disrupting the expires parameter
4 participants