Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix Kit docs scroll issue #4219

Closed
wants to merge 6 commits into from
Closed

Try to fix Kit docs scroll issue #4219

wants to merge 6 commits into from

Conversation

PH4NTOMiki
Copy link
Contributor

Fixes #4216 hopefully.

@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2022 •
edited

⚠️ No Changeset found

Latest commit: 40d2acf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@PH4NTOMiki PH4NTOMiki mentioned this pull request Mar 4, 2022
Closed
benmccann
benmccann approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it works to me

we might need to send this to https://github.com/sveltejs/sites as well in case that's updated to the latest SvelteKit

@PH4NTOMiki PH4NTOMiki marked this pull request as draft March 4, 2022 19:22
@PH4NTOMiki
Copy link
Contributor Author

Closing, doesn't really fix the issue, just hides it. will try again

@PH4NTOMiki PH4NTOMiki closed this Mar 4, 2022
@PH4NTOMiki PH4NTOMiki deleted the fix-docs-hash-scroll branch March 4, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrolling to hash links is broken on Chrome
2 participants
@PH4NTOMiki @benmccann