Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] goto self can incorrectly result in 404 #4316 #4318

Merged
merged 5 commits into from Mar 14, 2022
Merged

[fix] goto self can incorrectly result in 404 #4316 #4318

merged 5 commits into from Mar 14, 2022

Conversation

aolose
Copy link
Contributor

@aolose aolose commented Mar 13, 2022

If shadow page is the last matching route and endpoint return 204, client will keep fallthrough to next, so you will get 404.

fix: #4316

test:

cd packages\kit\test\apps\basics
npx  playwright test -g 'The last matching route fallthrough'

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2022

⚠️ No Changeset found

Latest commit: 3542bce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goto self can incorrectly result in 404
2 participants