New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate event.params
before calling handle
#4344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
approved these changes
Mar 16, 2022
5 tasks
* expose event.routeKey - closes #3840 * change routeKey to routeId * rename routeKey to routeId, expose page.routeId * rename route.key -> route.id everywhere * adapter-node sure picked a weird time to stop typechecking * oops * Update .changeset/mean-crews-unite.md
rmunn
added a commit
to rmunn/kit
that referenced
this pull request
Apr 7, 2022
Because of how sveltejs#4345 was merged into sveltejs#4344, the script that automatically adds PR numbers to the changelog got the wrong PR number for the "Expose `event.routeId` and `page.routeId`" feature. This manual change to the CHANGELOG.md file fixes that minor error.
5 tasks
ignatiusmb
added a commit
that referenced
this pull request
Apr 7, 2022
* Update one incorrect PR number in changelog Because of how #4345 was merged into #4344, the script that automatically adds PR numbers to the changelog got the wrong PR number for the "Expose `event.routeId` and `page.routeId`" feature. This manual change to the CHANGELOG.md file fixes that minor error. * Update packages/kit/CHANGELOG.md Fix link destination as well as link text Co-authored-by: Ignatius Bagus <ignatius.mbs@gmail.com> Co-authored-by: Ignatius Bagus <ignatius.mbs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is made possible by #4330 — now that we can match routes without needing to load/run them, we can populate
event.params
before callinghandle
, instead of mutating theevent
object as we work our way through the route manifest.A nice follow-up would be to expose the route key, making it possible to address #3840 without introducing a new hook.
Closes #1194.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0