Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rest param type generation #4361

Merged
merged 2 commits into from Mar 17, 2022
Merged

Conversation

mrkishi
Copy link
Member

@mrkishi mrkishi commented Mar 16, 2022

Fixes #4327.

For type generation, we manually extract the param names from the path, but we missed the existence of the spread operator.

We could get the canonical list of params from the manifest data for routes, but we don't have them for components (layouts and errors). Perhaps the manifest data could be refactored a bit so this would be available, but I have no thoughtful opinions for now—this just removes the spread operator from the names.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2022

🦋 Changeset detected

Latest commit: 0964c28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 85d9231 into sveltejs:master Mar 17, 2022
@mrkishi mrkishi deleted the rest-param-typing branch March 17, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated types invalid for routes with a rest parameter
2 participants