Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fallback HTML file when prerendering is disabled #4443

Merged

Conversation

dimfeld
Copy link
Contributor

@dimfeld dimfeld commented Mar 24, 2022

Fixes #4441. With prerendering.enabled = false the fallback HTML file was not created.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Wasn't quite sure of the best way to test this. Looks like it would require creating a new sample app in the prerendering test directory with this configuration and a single test that the fallback file is written. Should I do that?

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2022

🦋 Changeset detected

Latest commit: 1fcd33c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Thank you!

@dimfeld dimfeld deleted the create-fallback-with-prerendering-disabled branch March 31, 2022 19:20
dimfeld added a commit to dimfeld/svelte-kit that referenced this pull request Apr 13, 2022
Rich-Harris added a commit that referenced this pull request Apr 13, 2022
* Revert #4443: Create fallback HTML file when prerendering is disabled

Fixes #4492

* Document `config.kit.prerender.entries: []` workaround for SPA mode

* add test

* tweak changeset

* lockfile

* Update packages/adapter-static/README.md

Co-authored-by: Rich Harris <hello@rich-harris.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapter-static does not create the fallback file when prerender.enabled = false
3 participants