Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document how to render nested error pages for 404s #4529

Merged
merged 1 commit into from
Apr 6, 2022
Merged

document how to render nested error pages for 404s #4529

merged 1 commit into from
Apr 6, 2022

Conversation

Rich-Harris
Copy link
Member

people struggle with this, we've had a bunch of confusing issues raised around it

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2022

⚠️ No Changeset found

Latest commit: 759fd9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris mentioned this pull request Apr 5, 2022
Closed
@Rich-Harris Rich-Harris linked an issue Apr 5, 2022 that may be closed by this pull request
Nested layouts are rendering inside parent layouts for error pages #1576
Closed
dreitzner
dreitzner approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@dreitzner dreitzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a great explanation and clarifies the issue for me

@benmccann benmccann added the documentation Improvements or additions to documentation label Apr 6, 2022
@Rich-Harris Rich-Harris merged commit 1330b85 into master Apr 6, 2022
@Rich-Harris Rich-Harris deleted the nested-error-404-docs branch April 6, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

@dreitzner dreitzner dreitzner approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested layouts are rendering inside parent layouts for error pages
3 participants
@Rich-Harris @benmccann @dreitzner