Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support https #462

Merged
merged 6 commits into from
Apr 2, 2021
Merged

support https #462

merged 6 commits into from
Apr 2, 2021

Conversation

tanhauhau
Copy link
Member

I want to support https when starting the server, but not sure how should we specify the config for cert, key, etc.

We could put it into svelte.config.js, but i feel it might be duplicated from vite's https://vitejs.dev/config/#server-https ?

@benmccann
Copy link
Member

Do we want this for svelte-kit start or for the adapters?

@Conduitry
Copy link
Member

Do we really want to worry about this, or want to encourage people to do SSL in Node? Generally people should be using a separate reverse proxy for this.

@antony
Copy link
Member

antony commented Mar 7, 2021

I do see people occasionally request https in dev, and having a built-in https method which generates certificate is a significant boost for them. Trying to do the same with Sapper right now is pretty dificult.

There are certain libs which won't work unless you can set up SSL in dev, so I'm in favour of this.

For prod, no, we should not be encouraging node SSL or self-signed certificates, so this shouldn't go near the adapters.

@tanhauhau
Copy link
Member Author

so does it mean, it's better to be in svelte-kit dev (allowing testing https in development mode) than svelte-kit start

@benmccann
Copy link
Member

I would think if it were only going to be in one then svelte-kit dev would make more sense. Though if it's in one it probably makes sense to be in both

@Rich-Harris Rich-Harris mentioned this pull request Mar 15, 2021
@benmccann benmccann added the feature request New feature or request label Mar 24, 2021
packages/kit/src/cli.js Outdated Show resolved Hide resolved
@Rich-Harris Rich-Harris merged commit 24fab19 into master Apr 2, 2021
@Rich-Harris Rich-Harris deleted the tanhauhau/supports-https branch April 2, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants