Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudflare): more restrictive cache conditions #4669

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

lukeed
Copy link
Member

@lukeed lukeed commented Apr 20, 2022

Should close #4668 and handle similar requests I've received in DMs / Discord. This solution is a hold-over until the maxage (or similar) property has a tie-in to the cache-control header directly.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2022

🦋 Changeset detected

Latest commit: 534f09e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit b228fb5 into master Apr 20, 2022
@Rich-Harris Rich-Harris deleted the chore/cache-cloudflare branch April 20, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user-agent header always the same in cloudflare pages
2 participants