Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to target: node14.8 #4742

Merged
merged 3 commits into from
Apr 26, 2022
Merged

default to target: node14.8 #4742

merged 3 commits into from
Apr 26, 2022

Conversation

Rich-Harris
Copy link
Member

Fixes #1538, where I recommended that people do async setup work in src/hooks.js (or any other module, really) using top-level await. This works wonderfully in development, but it turns out svelte-kit build fails because Vite runs everything through esbuild (not sure why, if I'm perfectly honest, but that's a separate conversation) and we currently use target: 'es2020' which doesn't allow top-level await:

chunks/hooks-4fb5bb73.js:206:0: ERROR: Top-level await is not available in the configured target environment ("es2020")

This changes it to node16. I tried node14 at first, but that still didn't work even though top-level await definitely is supported there. I think this is probably fine, and at any rate, you can override it in config.kit.vite.build.target.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2022

🦋 Changeset detected

Latest commit: dcc7a12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bluwy
Copy link
Member

bluwy commented Apr 26, 2022

Vite runs everything through esbuild

It's using esbuild in the renderChunk() phase for minification. (source)

I tried node14 at first, but that still didn't work even though top-level await definitely is supported there

esbuild keeps a compat table for top level await. It only exists in 14.8, so specifying node14.8 should work too.

@Rich-Harris
Copy link
Member Author

specifying node14.8 should work too

nice, it does

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the package.json have "node": ">=14.13" so we should be safe with the change too.

Co-authored-by: Conduitry <git@chor.date>
@digitaldeus
Copy link

Hi is it possible to add this to the vercel adapter as well? Building to vercel still fails with top-level await errors and looks like that adapter is set to node14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hook for initialization?
4 participants