Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move RequestEvent and ResolveOptions as public types #4809

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

#4805 only explicitly requested moving RequestEvent to index.d.ts, but ResolveOptions is also part of Handle's input API, so I moved it too. If, for some reason, we don't want that to be a publicly-accessible type, I'll move it back.

Fixes #4805.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 3, 2022

🦋 Changeset detected

Latest commit: a9cc9e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ignatiusmb ignatiusmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort the changes alphabetically

@elliott-with-the-longest-name-on-github
Copy link
Contributor Author

@ignatiusmb

Sorry about that! Been on vacation. Didn't even think to check for sorting -- I figured that was something the linter handled. Done!

@ignatiusmb ignatiusmb changed the title feat: Moved ResolveOptions and RequestEvent to public - fixes #4805 move RequestEvent and ResolveOptions as public types May 16, 2022
Copy link
Member

@ignatiusmb ignatiusmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Rich-Harris Rich-Harris merged commit 720ba29 into sveltejs:master May 18, 2022
@Rich-Harris
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module '"@sveltejs/kit"' declares 'RequestEvent' locally, but it is not exported
6 participants