Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow %-encoding in route filenames #5056

Merged
merged 8 commits into from
Jul 8, 2022
Merged

Allow %-encoding in route filenames #5056

merged 8 commits into from
Jul 8, 2022

Conversation

Rich-Harris
Copy link
Member

Closes #5029. I'm at my least confident when dealing with anything encoding-related, so would appreciate a sanity check on this one

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2022

🦋 Changeset detected

Latest commit: 3b295b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

Is this a breaking change? Is this related to requiring all special characters in routes to be URL-encoded in the path names - or is that work separate? (Did it already happen and I missed it?)

@Rich-Harris
Copy link
Member Author

That's separate — this is basically just fixing a bug in how Vite names chunks if percent-encoded characters are involved

@Rich-Harris
Copy link
Member Author

I don't think it's a breaking change

@benmccann
Copy link
Member

I think this should work, but we should document it

This would be a breaking change for anyone who has % in their route as they'll now be required to encode it as %25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

routes with %40 not working
3 participants