-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check extensions for param matcher files #5085
Conversation
🦋 Changeset detectedLatest commit: db5d543 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -267,6 +267,7 @@ export default function create_manifest_data({ | |||
if (fs.existsSync(config.kit.files.params)) { | |||
for (const file of fs.readdirSync(config.kit.files.params)) { | |||
const ext = path.extname(file); | |||
if (!['.js', '.ts'].includes(ext)) break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it should be continue
here? maybe i'm wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I'm wrong! It should be continue
.
I fixed it, thank you.
Thank you! I wonder if we should rename |
That sounds good! |
That's a bit confusing because you wouldn't expect |
@h8gi it looks like this PR needs a rebase |
thank you! |
I get error messages (
"Matcher names must match /^[a-zA-Z_][a-zA-Z0-9_]*$/ — "${file}" is invalid"
) when my emacs creates backup files (like#[id].js#
) in /params directory.I think only
.js
and.ts
files should be included inmatchers
.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0