Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get client IP from Context object rather than the request header #5473

Merged
merged 2 commits into from
Jul 12, 2022
Merged

feat: get client IP from Context object rather than the request header #5473

merged 2 commits into from
Jul 12, 2022

Conversation

ericapisani
Copy link
Contributor

Originally the Edge function integrations were written under the assumption that we'd need to get the client IP from the request header.

However, the client IP is available in the Netlify Context object, so updating the adapter to reference that object rather than the request header.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2022

🦋 Changeset detected

Latest commit: 337dc79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-netlify Minor
@sveltejs/adapter-auto Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 31fbb1c into sveltejs:master Jul 12, 2022
@Rich-Harris
Copy link
Member

thank you!

@ericapisani ericapisani deleted the ep/implement-client-ip-through-context-obj branch July 12, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants