Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore invalid accept header values instead of throwing an error #5502

Conversation

elikoga
Copy link
Contributor

@elikoga elikoga commented Jul 13, 2022

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
    • User encountered clients sending invalid accept header values in the wild, resulting in 500 error codes in logs.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0
    • minor change, so I don't think this needs a changelog

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2022

🦋 Changeset detected

Latest commit: c66fa25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you — can we use map instead of flatMap? feels slightly circuitous to create extra arrays only to unwrap them. made suggestions in the relevant places

packages/kit/src/utils/http.js Outdated Show resolved Hide resolved
packages/kit/src/utils/http.js Outdated Show resolved Hide resolved
packages/kit/src/utils/http.js Outdated Show resolved Hide resolved
packages/kit/src/utils/http.js Show resolved Hide resolved
packages/kit/src/utils/http.js Outdated Show resolved Hide resolved
elikoga and others added 2 commits July 13, 2022 18:12
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
@Rich-Harris
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept header parsing possibly too strict
2 participants