Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the reader error #5616

Merged

Conversation

repsac-by
Copy link
Contributor

@repsac-by repsac-by commented Jul 19, 2022

The reader can throw an exception if there is no interception, then the application will crashing.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2022

🦋 Changeset detected

Latest commit: f80a304

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Thank you! Is this the sort of thing it's possible to add a test for, or is it more unpredictable than that?

@repsac-by
Copy link
Contributor Author

repsac-by commented Jul 19, 2022

Thank you! Is this the sort of thing it's possible to add a test for, or is it more unpredictable than that?

This is possible if it is possible to expect the server to survive and not crash with an error. We cannot expect exactly a response from the server, since it will be interrupted in any case.

@repsac-by
Copy link
Contributor Author

I think to make two requests, if the second one was successful, then the server is alive. I will try to implement.

@Rich-Harris
Copy link
Member

thank you!

@repsac-by repsac-by deleted the handle-the-output-stream-errors branch September 25, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants