Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle circular dependencies in dynamic imports #5619

Merged
merged 2 commits into from
Jul 19, 2022
Merged

handle circular dependencies in dynamic imports #5619

merged 2 commits into from
Jul 19, 2022

Conversation

Rich-Harris
Copy link
Member

closes #5399

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2022

🦋 Changeset detected

Latest commit: 664963c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 9de3435 into master Jul 19, 2022
@Rich-Harris Rich-Harris deleted the gh-5399 branch July 19, 2022 18:03
camargo added a commit to NASA-AMMOS/aerie-ui that referenced this pull request Jul 19, 2022
- Use Kit 381 for fix sveltejs/kit#5619
- Remove obsolete patch-node-modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

next.360 build fails with "Maximum call stack size exceeded" for large dynamic imports
2 participants