Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only normalise internal URLs #5645

Merged
merged 4 commits into from Jul 21, 2022
Merged

only normalise internal URLs #5645

merged 4 commits into from Jul 21, 2022

Conversation

Rich-Harris
Copy link
Member

fixes #5087, by only normalising URLs we're navigating to once we've established that it's a page within the app

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2022

🦋 Changeset detected

Latest commit: 5cd877b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

can't reproduce these failures locally. hmm

@Rich-Harris
Copy link
Member Author

oh hang on yes i can. they're in adapter-static tests, not kit 🤦

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I have a nagging feeling we should be able to test this in a lighter way, but don't have any immediate suggestions. I think Routify and React Router do some unit tests by mocking the browser, which might work here longer-term

@Rich-Harris
Copy link
Member Author

Maybe we could use network mocking https://playwright.dev/docs/test-configuration#network-mocking. I haven't used it so don't know if it's suitable, but possibly worth a try

@Rich-Harris Rich-Harris merged commit 6965e25 into master Jul 21, 2022
@Rich-Harris Rich-Harris deleted the gh-5087 branch July 21, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trailingSlash: "always" changes external URLs
2 participants