fix: builder.copy is not a function while building with adapter-vercel #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrsep
changed the title
wiesson
reviewed
Mar 24, 2021
antony
requested changes
Mar 24, 2021
Add @sveltejs/kit/filesystem copy function to builder.
|
Hi @antony, I've updated the PR and added the copy function to the builder function and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that the
builder.copyline was replacing a line that calls the copy function in @sveltejs/app-utils/files. I found that the same function is now exported by@sveltejs/kit/filesystem. So I tried replacing builder.copy with the copy function from@sveltejs/kit/filesystem.I've tested this on the realworld.svelte.dev example project by temporarily replacing its adapter-node with adapter-vercel and it seems to be working.
Fixes #617.