Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle non-prod dependencies with esbuild #6372

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Conversation

Rich-Harris
Copy link
Member

This closes #3176, by always bundling dev dependencies using esbuild. Supersedes #6301.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2022

🦋 Changeset detected

Latest commit: cf6bfa2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris mentioned this pull request Aug 29, 2022
5 tasks
@benmccann
Copy link
Member

It's probably worth adding something to the adapter-node readme saying that devDependencies will be bundled and dependencies will not so that people know what to put where

@gterras
Copy link

gterras commented Aug 29, 2022

It's probably worth adding something to the adapter-node readme saying that devDependencies will be bundled and dependencies will not so that people know what to put where

Also maybe a general note explaining the difference since it's less obvious than a common node project, like the Sapper docs did.

@AlexRMU
Copy link

AlexRMU commented Aug 29, 2022

What about minification of the entire server part and bundling of prod dependencies?

@Rich-Harris
Copy link
Member Author

There's really nothing to be gained from minifying server-side code except making it harder to debug. As the README says, if you want a dependency to be bundled, move it to devDependencies

@AlexRMU
Copy link

AlexRMU commented Aug 30, 2022

My build weighs 120 MB, which is 3 times more than node 16 alpine. It's sad. You can make minification optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide ability to bundle dev dependencies for Node adapter
5 participants