Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate dynamic env types #6413

Merged
merged 4 commits into from
Aug 30, 2022
Merged

Generate dynamic env types #6413

merged 4 commits into from
Aug 30, 2022

Conversation

Rich-Harris
Copy link
Member

Closes #6202.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2022

🦋 Changeset detected

Latest commit: 5d50358

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/kit Patch
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

'@sveltejs/kit': patch
---

[breaking] remove App.PrivateEnv and App.PublicEnv in favour of generated types
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[breaking] remove App.PrivateEnv and App.PublicEnv in favour of generated types
[breaking] remove App.PrivateEnv and App.PublicEnv in favor of generated types

Filthy european

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇬🇧

'@sveltejs/kit': patch
---

[breaking] remove App.PrivateEnv and App.PublicEnv in favour of generated types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[breaking] remove App.PrivateEnv and App.PublicEnv in favour of generated types
[breaking] remouve App.PrivateEnv and App.PublicEnv in favour of generated types

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇬🇧

@tcc-sejohnson
Copy link
Contributor

tcc-sejohnson commented Aug 30, 2022

All joking aside, LGTM.

edit: Assuming Safari issues are just flakiness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better typing for $env/dynamic/*
3 participants