New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run svelte-kit sync in all workspace directories #6949
Conversation
🦋 Changeset detectedLatest commit: 2d60a74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I have one related improvement suggestion
What about other monorepo/workspace solutions (pnpm, yarn, lerna?). Do they have similar issues? At least pnpm uses a different way to declare workspace packages Does |
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Conduitry <git@chor.date>
AFAIK — certainly for pnpm — the package will be 'installed' in each workspace directory that uses it. npm is different in that packages are only installed at the workspace root, hence the need to check for a
It does not. Definitely an edge case but I can add a check for that |
Closes #6617. In the case where
@sveltejs/kit
is installed to an npm workspace root, we runsvelte-kit sync
in all the directories specified inpkg.workspaces
, taking account of things like./packages/*
. (Though I've just read https://docs.npmjs.com/cli/v7/configuring-npm/package-json#workspaces and it seems that more complex globbing patterns are allowed, so this probably needs to use a globbing library.)Difficult to add tests for this, so I didn't.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0