Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run svelte-kit sync in all workspace directories #6949

Merged
merged 8 commits into from Sep 22, 2022
Merged

Conversation

Rich-Harris
Copy link
Member

Closes #6617. In the case where @sveltejs/kit is installed to an npm workspace root, we run svelte-kit sync in all the directories specified in pkg.workspaces, taking account of things like ./packages/*. (Though I've just read https://docs.npmjs.com/cli/v7/configuring-npm/package-json#workspaces and it seems that more complex globbing patterns are allowed, so this probably needs to use a globbing library.)

Difficult to add tests for this, so I didn't.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2022

🦋 Changeset detected

Latest commit: 2d60a74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have one related improvement suggestion

packages/kit/postinstall.js Show resolved Hide resolved
@dominikg
Copy link
Member

What about other monorepo/workspace solutions (pnpm, yarn, lerna?). Do they have similar issues? At least pnpm uses a different way to declare workspace packages

Does sync validate that it is called on a package using svelte-kit? If not the current implementation in this PR could lead to problems in a workspace that mix kit and other svelte projects.

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Conduitry <git@chor.date>
@Rich-Harris
Copy link
Member Author

What about other monorepo/workspace solutions (pnpm, yarn, lerna?). Do they have similar issues?

AFAIK — certainly for pnpm — the package will be 'installed' in each workspace directory that uses it. npm is different in that packages are only installed at the workspace root, hence the need to check for a pkg.workspaces

Does sync validate that it is called on a package using svelte-kit?

It does not. Definitely an edge case but I can add a check for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants