Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] bump undici for multipart form data support #7131

Merged
merged 5 commits into from Oct 3, 2022

Conversation

Conduitry
Copy link
Member

This upgrades the version of undici used by Kit to one that support multipart form data, removes node-fetch as a dependency, and removes the hack in polyfills.js.

It also removes node-fetch as a (dev) dependency to adapter-node, because it was only being used in tests, which are currently not being run. We'll have to revisit this later anyway if we want to run those tests in CI, at which point we can hopefully rewrite them to use something other than node-fetch.

There is still node-fetch@2.6.7 in our tree via some other dependencies that we can't do much about, but this PR is able to remove the node-fetch@3 dependency.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022

🦋 Changeset detected

Latest commit: bda2832

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit c1ee512 into sveltejs:master Oct 3, 2022
@github-actions github-actions bot mentioned this pull request Oct 3, 2022
@Conduitry Conduitry deleted the undici-bump-multipart branch October 3, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants