Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefix all route IDs with / #7338

Merged
merged 2 commits into from
Oct 21, 2022
Merged

prefix all route IDs with / #7338

merged 2 commits into from
Oct 21, 2022

Conversation

Rich-Harris
Copy link
Member

closes #7332

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: c7a9c4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dummdidumm
dummdidumm approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Any thoughts on the warning I proposed in #7332?

@Rich-Harris
Copy link
Member Author

I think @Conduitry is right, it will be annoying to have that warning appear once everyone has already made the change

@Rich-Harris Rich-Harris merged commit f5b45ca into master Oct 21, 2022
@Rich-Harris Rich-Harris deleted the gh-7332 branch October 21, 2022 16:17
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Merged
brunnerh added a commit to brunnerh/kit that referenced this pull request Nov 2, 2022
@brunnerh
Add missing slash to routeId JS doc
7d62c7e 
Implementation was changed in sveltejs#7338
@brunnerh brunnerh mentioned this pull request Nov 2, 2022
Merged
5 tasks
Rich-Harris pushed a commit that referenced this pull request Nov 2, 2022
@brunnerh
[docs] Add missing routeId slashes (#7469)
39b7ef5 
* Add missing slash to `routeId` JS doc

Implementation was changed in #7338

* Add another missing slash

* Add missing slashes in `Page` and `RequestEvent` docs.
@hyunbinseo hyunbinseo mentioned this pull request Nov 15, 2022
Merged
5 tasks
dummdidumm pushed a commit that referenced this pull request Nov 15, 2022
@hyunbinseo
[docs] prefix route.id examples with / (#7658)
20e1f92 
Reference #7338
@juranki juranki mentioned this pull request Jan 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefix all route IDs with /
3 participants
@Rich-Harris @dummdidumm @ignatiusmb