Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] get type gen working again #7370

Merged
merged 1 commit into from Oct 24, 2022
Merged

[fix] get type gen working again #7370

merged 1 commit into from Oct 24, 2022

Conversation

dummdidumm
Copy link
Member

since the routeId has changed, the matching logic needs an update

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

since the routeId has changed, the matching logic needs an update
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2022

🦋 Changeset detected

Latest commit: e95840d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dominikg
Copy link
Member

Is this new routeId leading slash a breaking change? Or to rephrase: do we consider the manifest format public api or is it internal?

@dummdidumm
Copy link
Member Author

that change was marked as breaking, since you also can access it at runtime through event.routeId in load

@dummdidumm dummdidumm merged commit 3d765b8 into master Oct 24, 2022
@dummdidumm dummdidumm deleted the fix-types-gen branch October 24, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants