Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] harmonize cookie path and add dev time warnings #7416

Merged
merged 2 commits into from Oct 28, 2022
Merged

Conversation

dummdidumm
Copy link
Member

  • Warnings will be logged to the console if it's detected that there's likely misusage of the path parameter.
  • More documentation
  • Fix mismatch of cookie path between /foo and /foo/__data.json server-load calls by emulating browser behavior of the default path

Fixes #6609

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

- Warnings will be logged to the console if it's detected that there's likely misusage of the path parameter.
- More documentation
- Fix mismatch of cookie path between /foo and /foo/__data.json server-load calls by emulating browser behavior of the default path

Fixes #6609
@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2022

🦋 Changeset detected

Latest commit: 7567c53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit dd7f3b4 into master Oct 28, 2022
@Rich-Harris Rich-Harris deleted the cookie-path branch October 28, 2022 15:50
@Rich-Harris Rich-Harris mentioned this pull request Oct 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cookies.delete not working when using form enhance
3 participants