Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump devalue version #7466

Merged
merged 2 commits into from Nov 2, 2022
Merged

bump devalue version #7466

merged 2 commits into from Nov 2, 2022

Conversation

Rich-Harris
Copy link
Member

The newest version of devalue only de-duplicates non-primitives. That means that a value like [null, null] is serialized sensibly:

<script type="module" data-sveltekit-hydrate="1vcz4c4">
  import { start } from "./_app/immutable/start-050325ff.js";

  start({
    env: {},
    hydrate: {
      status: 200,
      error: null,
      node_ids: [0, 3],
      params: {},
      routeId: "/",
-      data: (function(a){return [a,a]}(null)),
+      data: [null,null],
      form: null
    },
    paths: {"base":"","assets":""},
    target: document.querySelector('[data-sveltekit-hydrate="1vcz4c4"]').parentNode,
    trailing_slash: "never"
  });
</script>

It also makes it much less likely that you'd end up with an IIFE with too many arguments. Between that and the fact that we now use devalue.stringify rather than devalue.uneval, we can close #6672.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2022

🦋 Changeset detected

Latest commit: 5b84af2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

hmm. weird that lint's failing here and not on any recent changes in master. maybe the devalue types changed?

@dummdidumm
Copy link
Member

Not sure how this didn't fail before, made a drive-by-fix

@dummdidumm dummdidumm merged commit 843e05d into master Nov 2, 2022
@dummdidumm dummdidumm deleted the bump-devalue branch November 2, 2022 08:08
@github-actions github-actions bot mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

too many function arguments when returning large datasets from +page.server.js
3 participants