Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] dev time service workers #7597

Merged
merged 3 commits into from
Nov 11, 2022
Merged

[feat] dev time service workers #7597

merged 3 commits into from
Nov 11, 2022

Conversation

Rich-Harris
Copy link
Member

Closes #5479. In development, this intercepts requests for /service-worker.js and imports the src/service-worker.js module, and creates a virtual $service-worker module that includes all the usual exports. build and prerendered are empty arrays.

I haven't added tests for this because I'm not really sure what they should look like.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2022

🦋 Changeset detected

Latest commit: 2a07163

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AlbertMarashi
Copy link

@Rich-Harris @dummdidumm I believe firefox does not support imports inside of service workers, and this is creating errors during development in firefox. Any idea what we should do?

@dummdidumm
Copy link
Member

As stated in the documentation, this needs support from the browser, so you'd need to use Chromium-based browsers during dev to test this. The alternative is to build and check the result in Preview mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service Worker Compilation during Development
3 participants