Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write redirects for prerendered pages with trailing slashes #7747

Merged
merged 4 commits into from Nov 21, 2022
Merged

Conversation

Rich-Harris
Copy link
Member

fixes #7725. The prerendered page wasn't being served because the overrides config in .vercel/output/config.json can't have a path value with a trailing slash. To get the correct behaviour we have to remove the trailing slash, and also add two entries to the routes config for each prerendered page:

{ "src": "/the-path/", "dest": "/the-path" },
{ "src": "/the-path", "status": 308, "headers": { "Location": "/the-path/" } }

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2022

🦋 Changeset detected

Latest commit: b9142f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines 185 to 195
console.log(
JSON.stringify(
{
version: 3,
routes,
overrides
},
null,
' '
)
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended to also be logging this to stdout, or was this just for debugging? Will that make things too noisy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not intended. oops

@dummdidumm dummdidumm merged commit e354459 into master Nov 21, 2022
@dummdidumm dummdidumm deleted the gh-7725 branch November 21, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerendered pages with trailing slash 404 when directly loaded
3 participants