Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update reference to getClientAddress() #7907

Merged
merged 2 commits into from Dec 2, 2022
Merged

[docs] update reference to getClientAddress() #7907

merged 2 commits into from Dec 2, 2022

Conversation

aradalvand
Copy link
Contributor

@aradalvand aradalvand commented Dec 2, 2022

The adapter-node README file mentions RequestEvent.clientAddress, but that's now a function: RequestEvent.getClientAddress().

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2022

🦋 Changeset detected

Latest commit: 3a52085

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

#6237 for reference

@benmccann benmccann changed the title Fix adapter-node README [docs] update reference to getClientAddress() Dec 2, 2022
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a changeset so the docs will be fixed in the published package. I feel like we should probably separate docs from publishing, but I guess that's for another time

@benmccann benmccann merged commit f4fe14b into sveltejs:master Dec 2, 2022
@github-actions github-actions bot mentioned this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pkg:adapter-node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants