Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Response type from node-fetch to type our own fetch responses #799

Merged
merged 4 commits into from
Mar 31, 2021
Merged

Use Response type from node-fetch to type our own fetch responses #799

merged 4 commits into from
Mar 31, 2021

Conversation

furudean
Copy link
Contributor

@furudean furudean commented Mar 31, 2021 •
edited
Loading

Fixes #691

@furudean furudean marked this pull request as draft March 31, 2021 18:48
@furudean furudean changed the title Use Response type node-fetch to type our own fetch Use Response type from node-fetch to type our own fetch Mar 31, 2021
@furudean furudean changed the title Use Response type from node-fetch to type our own fetch Use Response type from node-fetch to type our own fetch responses Mar 31, 2021
@furudean furudean marked this pull request as ready for review March 31, 2021 19:01
@Rich-Harris Rich-Harris merged commit d9ce2a2 into sveltejs:master Mar 31, 2021
@Rich-Harris
Copy link
Member

thank you!

@furudean furudean deleted the fix-fetch-type branch March 31, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load fetch types are wrong
2 participants
@furudean @Rich-Harris