Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] load errorTemplate from correct location #8096

Merged
merged 1 commit into from Dec 12, 2022
Merged

Conversation

dummdidumm
Copy link
Member

The alternative would be to move the "set a fallback error.html path if not set" logic into load_error_page, which @Rich-Harris added here

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2022

🦋 Changeset detected

Latest commit: 9383579

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

I think the other option is preferable — vite/dev/index.js is already an unwieldy monster, so anything to keep logic out of there is a good thing, and the less we need to restart the server the better

@Conduitry Conduitry changed the title [fix] restart vite on error.html add/remove [fix] load errorTemplate from correct location Dec 12, 2022
@Rich-Harris Rich-Harris merged commit ba95b64 into master Dec 12, 2022
@Rich-Harris Rich-Harris deleted the error-html branch December 12, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants