[fix] don't de/encode initial and explicit string headers #8113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 89635ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Dec 13, 2022
|
|
||
| const normalized_url = normalize_path(url.pathname, trailing_slash); | ||
| // Emulate browser-behavior: if the cookie is set at '/foo/bar', its path is '/foo' | ||
| const default_path = normalized_url.split('/').slice(0, -1).join('/') || '/'; | ||
|
|
||
| if (dev) { | ||
| // TODO this could theoretically be wrong if the cookie was set unencoded? |
There was a problem hiding this comment.
I'm not sure it makes sense to add a todo because I don't know how we'd ever fix it. Maybe change the comment like yhis
Suggested change
| // TODO this could theoretically be wrong if the cookie was set unencoded? | |
| // This could be wrong if the cookie was set unencoded | |
| // but since it's just for printing a debug message we can live with that |
There was a problem hiding this comment.
I have some nebulous thoughts how this could be done, for example through never decoding it and then updating that object with an unencoded version of the new cookies, but want to look into that later - so I'd like to keep the TODO for now (but you may very well be right!).
benmccann
approved these changes
Dec 13, 2022
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7929
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0