Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] redirects from actions don't honor the provided status code #8210

Merged

Conversation

coryvirok
Copy link
Contributor

@coryvirok coryvirok commented Dec 18, 2022

Fixes #8209

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2022

🦋 Changeset detected

Latest commit: e995df1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 18, 2022

@coryvirok is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Dec 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kit 🔄 Building (Inspect) Dec 19, 2022 at 9:53AM (UTC)

@dummdidumm
Copy link
Member

Thank you! Could you add a changeset (patch version)?

@dummdidumm dummdidumm changed the title fixes #8209 - redirects from actions don't honor the provided status code [fix] redirects from actions don't honor the provided status code Dec 19, 2022
@dummdidumm dummdidumm merged commit 89b8d94 into sveltejs:master Dec 20, 2022
@github-actions github-actions bot mentioned this pull request Dec 20, 2022
robBowes pushed a commit to robBowes/kit that referenced this pull request Dec 20, 2022
…eltejs#8210)

fixes sveltejs#8209

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect in action does not respect status code
2 participants