Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add prerendered assets to Vercel config #8332

Merged
merged 5 commits into from Jan 6, 2023

Conversation

pawelblaszczyk5
Copy link
Contributor

Hello!
Solves #8331

Before prerendered data.json or other non-html pages weren't included in Vercel config. It correctly adds them to it.

I monkey patched the change to my private project and it correctly worked. While fixing I found that it's also applicable to adapter Vercel. However, I'm not familiar with the codebase and the adapters system, so I'm not sure about the correctness of my approach. I'm also not sure about the test for the change but can provide one if given some advice and it's needed 😀

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2023

🦋 Changeset detected

Latest commit: 048dcfe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-vercel Patch
@sveltejs/adapter-static Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kit 🔄 Building (Inspect) Jan 4, 2023 at 11:40AM (UTC)

@Rich-Harris
Copy link
Member

Thank you. adapter-vercel was totally fine (except for an unrelated bug — it was adding immutable cache headers to non-immutable assets), so rather than changing it, I've copied the logic from there into adapter-static. Using overrides is preferable to using rewrite routes.

(This does result in some duplication, but it's at least explicit. Probably not worth creating a new package that they both depend on in order to reduce that duplication.)

@pawelblaszczyk5
Copy link
Contributor Author

Thanks a lot, I wasn't sure, because I was surprised by the totally different code between these two. Good idea to unify them 😊

@Rich-Harris Rich-Harris merged commit 4792ded into sveltejs:master Jan 6, 2023
@github-actions github-actions bot mentioned this pull request Jan 6, 2023
@pawelblaszczyk5 pawelblaszczyk5 deleted the vercel-static-fix branch January 6, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants