Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish missing files #8532

Merged
merged 2 commits into from
Jan 15, 2023
Merged

fix: publish missing files #8532

merged 2 commits into from
Jan 15, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 15, 2023

Fix #8530

npm and pnpm includes the file in pkg.main to publish by default. Since #8519 removed the pkg.main field, we forgot to add the index.js file to the pkg.files field, causing it to be missing after publish.

This PR updates the pkg.files field

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2023

🦋 Changeset detected

Latest commit: b937664

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-static Patch
@sveltejs/adapter-vercel Patch
@sveltejs/amp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +20 to +24
"files": [
"index.js",
"index.d.ts",
"platforms.js"
],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we were publishing all files previously: https://www.npmjs.com/package/@sveltejs/adapter-static?activeTab=explore. I scoped this down to the ones we need.

@arackaf
Copy link

arackaf commented Jan 15, 2023

Holy crap thanks for the fast fix - this is much appreciated! (but not at all expected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad publish in @sveltejs/adapter-auto@1.0.1 breaking all builds (Netlify Vercel etc)
3 participants