Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend the "nasty hack to silence harmless warnings"... #8593

Merged
merged 2 commits into from Jan 19, 2023

Conversation

simonsarris
Copy link
Contributor

...to include Error pages too, because when throwing 404s (etc), args[0] can also be:

"<Error> was created with unknown prop 'data'"

And this is not caught by the current regex. Instead, the regex only captures strings containing <Layout> or <Page>.

This is an extremely minor edit, and I anticipate no problems, alas I have not run tests.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

...to include Error pages too, because when throwing 404s (etc), `args[0]` can also be:

```
"<Error> was created with unknown prop 'data'"
```

And this is not caught by the current regex.
@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2023

🦋 Changeset detected

Latest commit: 5ff3dc7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit a77d079 into sveltejs:master Jan 19, 2023
@Rich-Harris
Copy link
Member

thank you! no worries re tests, would be overkill for this

@github-actions github-actions bot mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants