Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent unnecessary __data.json requests #8636

Merged
merged 42 commits into from
Jan 26, 2023
Merged

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jan 20, 2023

This will close #7967
Also fixes #8655

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2023

🦋 Changeset detected

Latest commit: ead8fa8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@arackaf
Copy link

arackaf commented Jan 20, 2023

👀

@benmccann
Copy link
Member

Why do we need to swap the order of the builds? One concern I have with that is that we've gotten requests not to do the server-side build for SPAs, etc. That becomes harder if the server-side build is the primary build

@Rich-Harris
Copy link
Member Author

You can't not do the server side build! Just because you're not rendering the body content doesn't mean you don't need a server.

The server needs to go first because the client manifest needs to know which nodes have server loads. We can't know that without doing the server build (and analysing it) before the client build.

@benmccann
Copy link
Member

If you're building a SPA with fallback page and no server side endpoints, what do you need the server for exactly?

@Rich-Harris
Copy link
Member Author

To generate the fallback page (while respecting things like transformPageChunk)

@dummdidumm
Copy link
Member

The CI fail seems to be consistent. Failed two times on Mac, both times with an error hinting that writeBundle did not resolve correctly (or in time?).

@Rich-Harris
Copy link
Member Author

Hmm. The most likely explanation for that would be that the cross-process communication failed for some reason and the promise never resolved, which makes me nervous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants