Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make site work when base path is configured #8678

Merged
merged 9 commits into from
Jan 23, 2023
Merged

chore: make site work when base path is configured #8678

merged 9 commits into from
Jan 23, 2023

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Jan 23, 2023

We've got a number of base path issues I've been looking at. It's helpful to be able to run the site with a base path so that I have something to debug against. I don't expect that we'll necessarily maintain kit.svelte.dev in a perfectly working state with base path, but it's helpful to have something nonetheless

I found one serious bug while working on this and fixed it in another PR (#8683)

This also bumps vite-imagetools which just fixed base path support in its latest release, so it was a good test of that as well

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2023

⚠️ No Changeset found

Latest commit: 06edecf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

I found one serious bug while working on this and fixed it as part of this PR

Can we open a separate PR for that, with a test?

@benmccann
Copy link
Member Author

Can we open a separate PR for that, with a test?

Done. I moved that code to #8683 and added a test

@Rich-Harris Rich-Harris merged commit 668c63e into master Jan 23, 2023
@Rich-Harris Rich-Harris deleted the site branch January 23, 2023 23:46
@Rich-Harris
Copy link
Member

nice

@benmccann benmccann added the paths.base bugs relating to `config.kit.paths.base` label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paths.base bugs relating to `config.kit.paths.base`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants