-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make site work when base path is configured #8678
Conversation
|
Can we open a separate PR for that, with a test? |
Done. I moved that code to #8683 and added a test |
nice |
We've got a number of base path issues I've been looking at. It's helpful to be able to run the site with a base path so that I have something to debug against. I don't expect that we'll necessarily maintain kit.svelte.dev in a perfectly working state with base path, but it's helpful to have something nonetheless
I found one serious bug while working on this and fixed it in another PR (#8683)
This also bumps
vite-imagetools
which just fixed base path support in its latest release, so it was a good test of that as well