fix: prevent overwriting of CloudFlare _headers file
#8693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 26ab757 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This reverts commit 4e27ca4.
benmccann
reviewed
Jan 24, 2023
| @@ -22,10 +22,6 @@ export default function () { | |||
|
|
|||
| const relativePath = posix.relative(tmp, builder.getServerDirectory()); | |||
|
|
|||
| builder.log.info( | |||
| `adapter-cloudfare is writing its own _headers file. If you have your own, you should duplicate the headers contained in: ${dest}/_headers` | |||
There was a problem hiding this comment.
If people had done this previously as we advised and now we are appending them, they will end up with duplicates. I don't know how much of an issue that is. Does this need to be considered a breaking change and major release?
There was a problem hiding this comment.
I think you're right about this being a breaking change. I never thought of that.
Are there any examples of existing configurations and how people have been getting around this?
Rich-Harris
approved these changes
Jan 27, 2023
|
thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8692
Adds the append flag
ato the file writing method for_headers.This appends the auto-generated headers to any existing
_headersfile copied from/staticor creates a new one if it doesn't exist (as it did before).Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.