Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly serialize request url when using load fetch #8876

Merged
merged 3 commits into from Feb 3, 2023
Merged

fix: correctly serialize request url when using load fetch #8876

merged 3 commits into from Feb 3, 2023

Conversation

eltigerchino
Copy link
Member

fixes #8852

Slices the origin from any client fetch request URLs so that they're always similar in format to fetches done on the server.

Also adjusts one of the tests to account for absolute URL fetches in shared load functions.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@eltigerchino eltigerchino changed the title fix: match client serialised data url check with server fix: correctly serialize request url when using load fetch Feb 3, 2023
packages/kit/src/runtime/client/client.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data serialization is broken if you are using full URL to API on your hostname
2 participants