Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client build minification #9012

Merged
merged 3 commits into from Feb 12, 2023
Merged

fix: client build minification #9012

merged 3 commits into from Feb 12, 2023

Conversation

gtm-nayan
Copy link
Contributor

@gtm-nayan gtm-nayan commented Feb 12, 2023

This fixes a regression from #8977 where vite_config is the resolved config so build.minify is defaulted to false for ssr builds if the user doesn't specify an option manually.

I think minify is the only relevant inline option that's overriden, so this should be the only one that needs special handling.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@Rich-Harris Rich-Harris merged commit 74cfa8d into master Feb 12, 2023
@Rich-Harris Rich-Harris deleted the fix-minify branch February 12, 2023 18:00
@Rich-Harris
Copy link
Member

nice catch!

@github-actions github-actions bot mentioned this pull request Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants