Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable experimental response streaming #9144

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

Rich-Harris
Copy link
Member

This enables streaming from serverless functions on Vercel (edge functions already support streaming)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@Rich-Harris
Copy link
Member Author

(Further context: despite the experimental label this is ready for widespread use, and in fact is used for Next's new route handlers. According to benchmarks it's indistinguishable in performance from the non-streaming version, so the recommendation from the relevant people at Vercel is that we should enable it by default — no need to add an option for it.)

@Rich-Harris Rich-Harris merged commit 72276ba into master Feb 21, 2023
@Rich-Harris Rich-Harris deleted the vercel-node-streaming branch February 21, 2023 14:59
@github-actions github-actions bot mentioned this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants