Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always generate 404.html #9294

Merged
merged 4 commits into from
Mar 3, 2023
Merged

always generate 404.html #9294

merged 4 commits into from
Mar 3, 2023

Conversation

Rich-Harris
Copy link
Member

If the user creates their own 404 route or static asset, that will be given priority.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@Rich-Harris Rich-Harris merged commit e59b2fc into master Mar 3, 2023
@Rich-Harris Rich-Harris deleted the gh-9011 branch March 3, 2023 20:24
@Rich-Harris
Copy link
Member Author

thanks @ajgeiss0702!

@danawoodman
Copy link
Contributor

danawoodman commented Mar 31, 2023

fwiw it appears this PR has broken adapter-cloudflare for anyone using something like an auth hook which shouldn't run during build: #9386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid static requests return index.html instead of 404
4 participants