Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid FOUC when using CSS modules in dev #9323

Merged
merged 1 commit into from Mar 6, 2023

Conversation

DrLoopFall
Copy link
Contributor

@DrLoopFall DrLoopFall commented Mar 5, 2023

Fixes #5019

Importing CSS modules causes flash of unstyled content, as an object is returned from Vite causing it to be injected as [object Object] inside the style tag.
Importing with ?inline, allows Vite to returns the CSS as string which can be used inside the style tag.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@benmccann benmccann requested a review from bluwy March 6, 2023 16:35
@Rich-Harris Rich-Harris merged commit 5dada25 into sveltejs:master Mar 6, 2023
@benmccann
Copy link
Member

Thank you @DrLoopFall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles flash when using CSS Modules in the development environment
4 participants